From: Jonian Guveli <jonian@hardpixel.eu>
Date: Sun, 31 Dec 2023 18:30:11 +0000 (+0200)
Subject: appMenu: Move setApp to null before destroy
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~281^2~2^2~200
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=6615d699852d9dfc3d6dd9f8efffdb7cf44b4b2f;p=gnome-shell.git

appMenu: Move setApp to null before destroy

Calling `setApp` after the menu has been destroyed results in error.
Moving the method before `super.destroy()` fixes the issue.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2998>
---

diff --git a/js/ui/appMenu.js b/js/ui/appMenu.js
index e3825a81e..1569aa6ce 100644
--- a/js/ui/appMenu.js
+++ b/js/ui/appMenu.js
@@ -199,9 +199,8 @@ export class AppMenu extends PopupMenu.PopupMenu {
 
     /** */
     destroy() {
-        super.destroy();
-
         this.setApp(null);
+        super.destroy();
     }
 
     /**